Messages in this thread | | | Date | Thu, 10 Aug 2023 07:59:15 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging: nvec: paz00: remove unneeded call to platform_set_drvdata() |
| |
On Wed, Aug 09, 2023 at 06:42:11PM +0300, Andrei Coardos wrote: > This function call was found to be unnecessary as there is no equivalent > platform_get_drvdata() call to access the private data of the driver. Also, > the private data is defined in this driver, so there is no risk of it being > accessed outside of this driver file. > > Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com> > ---
I think you are right, but why are we doing this? That one line is hardly a huge eyesore. It's all risk and no reward.
Have you tested this change on real hardware?
regards, dan carpenter
| |