Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH v2] riscv: mm: fix 2 instances of -Wmissing-variable-declarations | Date | Thu, 10 Aug 2023 12:44:03 -0700 | From | Palmer Dabbelt <> |
| |
On Tue, 08 Aug 2023 09:35:00 -0700, Nick Desaulniers wrote: > I'm looking to enable -Wmissing-variable-declarations behind W=1. 0day > bot spotted the following instance in ARCH=riscv builds: > > arch/riscv/mm/init.c:276:7: warning: no previous extern declaration > for non-static variable 'trampoline_pg_dir' > [-Wmissing-variable-declarations] > 276 | pgd_t trampoline_pg_dir[PTRS_PER_PGD] __page_aligned_bss; > | ^ > arch/riscv/mm/init.c:276:1: note: declare 'static' if the variable is > not intended to be used outside of this translation unit > 276 | pgd_t trampoline_pg_dir[PTRS_PER_PGD] __page_aligned_bss; > | ^ > arch/riscv/mm/init.c:279:7: warning: no previous extern declaration > for non-static variable 'early_pg_dir' > [-Wmissing-variable-declarations] > 279 | pgd_t early_pg_dir[PTRS_PER_PGD] __initdata __aligned(PAGE_SIZE); > | ^ > arch/riscv/mm/init.c:279:1: note: declare 'static' if the variable is > not intended to be used outside of this translation unit > 279 | pgd_t early_pg_dir[PTRS_PER_PGD] __initdata __aligned(PAGE_SIZE); > | ^ > > [...]
Applied, thanks!
[1/1] riscv: mm: fix 2 instances of -Wmissing-variable-declarations https://git.kernel.org/palmer/c/d2402048bc8a
Best regards, -- Palmer Dabbelt <palmer@rivosinc.com>
| ![\](/images/icornerr.gif) |