| Date | Thu, 10 Aug 2023 12:02:50 -0700 | From | Kees Cook <> | Subject | Re: [PATCH 17/17] [RFC] Makefile.extrawarn: turn on missing-prototypes again |
| |
On Thu, Aug 10, 2023 at 04:19:35PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > Over the years we went from > 1000 of warnings to under 100 earlier > this year, and I sent patches to address all the ones that I saw with > compile testing randcom configs on arm64, arm and x86 kernels. This is a > really useful warning, as it catches real bugs when there are mismatched > prototypes. In particular with kernel control flow integrity enabled, > those are no longer allowed. > > Move the options out of the W=1 section to have them enabled by > default. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > I'm sure there are still regressions with CONFIG_WERROR when this gets > turned on, but it's getting very close, so it might be best to already > enable this in linux-next but wait one extra merge window to have it in > mainline while the last fixes trickle in. > ---
Thanks for chasing all of these down!
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
-- Kees Cook
|