Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCH v1 02/14] futex: Extend the FUTEX2 flags | Date | Tue, 01 Aug 2023 10:49:29 +0200 |
| |
On Tue, Aug 01 2023 at 00:59, Peter Zijlstra wrote: > On Tue, Aug 01, 2023 at 12:43:24AM +0200, Thomas Gleixner wrote: > Which then gets people to write garbage like: > > futex_wake(add, 0xFFFF, 1, (union futex_flags){ .flags = FUTEX2_SIZE_U16 | FUTEX2_PRIVATE)); > or > futex_wake(add, 0xFFFF, 1, (union futex_flags){ .size = FUTEX2_SIZE_U16, private = true, )); > > You really want that ?
Well, people write garbage no matter what. So just keep the flags and make the names explicit.
Note to myself: /me shouldn't look at futex patches when tired
| |