Messages in this thread | | | From | Tomer Maimon <> | Date | Tue, 1 Aug 2023 11:43:30 +0300 | Subject | Re: [PATCH v3 4/4] arm64: dts: nuvoton: Add PECI controller node |
| |
Hi Iwona,
I have done r-b, could you do a small modification
On Thu, 27 Jul 2023 at 23:23, Iwona Winiarska <iwona.winiarska@intel.com> wrote: > > Add PECI controller node with all required information. > > Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com> > --- > arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi > index aa7aac8c3774..b8326bbe9fde 100644 > --- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi > +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi > @@ -68,6 +68,15 @@ apb { > ranges = <0x0 0x0 0xf0000000 0x00300000>, > <0xfff00000 0x0 0xfff00000 0x00016000>; > > + peci0: peci-controller@100000 { Please modify the peci0 to peci we have only one PECI controller. > + compatible = "nuvoton,npcm845-peci"; > + reg = <0x100000 0x1000>; > + interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clk NPCM8XX_CLK_APB3>; > + cmd-timeout-ms = <1000>; > + status = "disabled"; > + }; > + > timer0: timer@8000 { > compatible = "nuvoton,npcm845-timer"; > interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>; > -- > 2.40.1 >
Reviewed-by: Tomer Maimon <tmaimon77@gmail.com>
Thanks,
Tomer
| |