Messages in this thread | | | Date | Tue, 1 Aug 2023 09:34:18 +0200 | From | Thomas Weißschuh <> | Subject | Re: [PATCH v2 06/10] selftests/nolibc: make functions static if possible |
| |
On 2023-08-01 08:52:19+0200, Willy Tarreau wrote: > On Tue, Aug 01, 2023 at 07:30:13AM +0200, Thomas Weißschuh wrote: > > diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c > > index 1555759bb164..53a3773c7790 100644 > > --- a/tools/testing/selftests/nolibc/nolibc-test.c > > +++ b/tools/testing/selftests/nolibc/nolibc-test.c
> [..]
> > /* prepare what needs to be prepared for pid 1 (stdio, /dev, /proc, etc) */ > > -int prepare(void) > > +static int prepare(void) > > { > > struct stat stat_buf; > > > > @@ -1208,7 +1208,7 @@ static const struct test test_names[] = { > > { 0 } > > }; > > For these ones it will prevent gcc from putting breakpoints there, which > is counter-productive.
Indeed.
An alternative would be to add -g to CFLAGS (and remove -s from LDFLAGS). This way we get full debugability including breakpoints for everything.
I didn't find the reasoning for -s in LDFLAGS.
Thomas
| |