Messages in this thread | | | Date | Tue, 1 Aug 2023 23:35:00 +0100 | From | Andrew Cooper <> | Subject | Re: [patch v2 21/38] x86/cpu: Provide cpu_init/parse_topology() |
| |
On 01/08/2023 11:25 pm, Thomas Gleixner wrote: > --- a/arch/x86/kernel/cpu/common.c > +++ b/arch/x86/kernel/cpu/common.c > @@ -1688,7 +1688,7 @@ static void validate_apic_and_package_id > > apicid = apic->cpu_present_to_apicid(cpu); > > - if (apicid != c->topo.apicid) { > + if (WARN_ON_ONCE(apicid != c->topo.apicid)) { > pr_err(FW_BUG "CPU%u: APIC id mismatch. Firmware: %x APIC: %x\n",
While you're fixing this, care to remove the chaotic-evil path of mixing %u and %x with no 0x prefix?
~Andrew
| |