lkml.org 
[lkml]   [2023]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch v2 21/38] x86/cpu: Provide cpu_init/parse_topology()
    On 01/08/2023 11:25 pm, Thomas Gleixner wrote:
    > --- a/arch/x86/kernel/cpu/common.c
    > +++ b/arch/x86/kernel/cpu/common.c
    > @@ -1688,7 +1688,7 @@ static void validate_apic_and_package_id
    >
    > apicid = apic->cpu_present_to_apicid(cpu);
    >
    > - if (apicid != c->topo.apicid) {
    > + if (WARN_ON_ONCE(apicid != c->topo.apicid)) {
    > pr_err(FW_BUG "CPU%u: APIC id mismatch. Firmware: %x APIC: %x\n",

    While you're fixing this, care to remove the chaotic-evil path of mixing
    %u and %x with no 0x prefix?

    ~Andrew

    \
     
     \ /
      Last update: 2023-08-02 00:36    [W:5.081 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site