Messages in this thread | | | Date | Tue, 1 Aug 2023 08:37:21 +0200 | From | Marc Kleine-Budde <> | Subject | Re: [PATCH v3 net 1/2] net: stmmac: add new mode parameter for fix_mac_speed |
| |
On 31.07.2023 11:19:28, Shenwei Wang wrote: > A mode parameter has been added to the callback function of fix_mac_speed > to indicate the physical layer type. > > The mode can be one the following: > MLO_AN_PHY - Conventional PHY > MLO_AN_FIXED - Fixed-link mode > MLO_AN_INBAND - In-band protocol > > Also use short version of 'uint' to replace the 'unsigned int' in the > function definitions.
There are not many users of 'uint' in the kernel and it's not used in the stmmac driver so far. From my point of view I would not introduce it and stick to the standard 'unsigned int'.
Just my 2 cent, Marc
-- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung Nürnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 | [unhandled content-type:application/pgp-signature] | |