lkml.org 
[lkml]   [2023]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v9 03/10] serial: sc16is7xx: remove obsolete out_thread label
    On Mon, 31 Jul 2023 17:53:10 +0200
    Greg KH <gregkh@linuxfoundation.org> wrote:

    > On Tue, Jul 25, 2023 at 10:23:35AM -0400, Hugo Villeneuve wrote:
    > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
    > >
    > > Commit c8f71b49ee4d ("serial: sc16is7xx: setup GPIO controller later
    > > in probe") moved GPIO setup code later in probe function. Doing so
    > > also required to move ports cleanup code (out_ports label) after the
    > > GPIO cleanup code.
    > >
    > > After these moves, the out_thread label becomes misplaced and makes
    > > part of the cleanup code illogical.
    > >
    > > This patch remove the now obsolete out_thread label and make GPIO
    > > setup code jump to out_ports label if it fails.
    > >
    > > Fixes: c8f71b49ee4d ("serial: sc16is7xx: setup GPIO controller later in probe")
    > > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
    > > Reviewed-by: Lech Perczak <lech.perczak@camlingroup.com>
    > > Tested-by: Lech Perczak <lech.perczak@camlingroup.com>
    > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
    >
    > Why is this not ok for stable kernels yet it has a Fixes: tag?
    >
    > Please fix.
    >
    > thanks,
    >
    > greg k-h

    Hi,
    this is a somewhat particular case. It is a change that "fixes" some
    previously unseen consequence in original commit, but that does not
    result in any binary change in the end. That is why I decided not to
    put in a "stable" tag.

    If you want, maybe it would be simpler to remove the "Fixes" tag? I
    originally put this tag to have a reference to the original commit, but
    since it is already mentioned in the commit log message body, it can be
    removed.

    Hugo.

    \
     
     \ /
      Last update: 2023-08-01 19:31    [W:6.714 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site