Messages in this thread | | | Date | Mon, 10 Jul 2023 11:22:50 +0800 | Subject | Re: [PATCH v1 1/5] ASoC: dt-bindings: Add StarFive JH7110 dummy PWM-DAC transmitter | From | Hal Feng <> |
| |
On Sat, 1 Jul 2023 10:17:51 +0200, Krzysztof Kozlowski wrote: > On 30/06/2023 03:57, Hal Feng wrote: >> On Mon, 26 Jun 2023 17:34:56 +0200, Krzysztof Kozlowski wrote: >>> On 26/06/2023 13:09, Hal Feng wrote: >>>> Add bindings for StarFive JH7110 dummy PWM-DAC transmitter. >>> >>> ... >>> >>>> +required: >>>> + - compatible >>>> + - "#sound-dai-cells" >>>> + >>>> +additionalProperties: false >>>> + >>>> +examples: >>>> + - | >>>> + pwmdac-dit { >>>> + compatible = "starfive,jh7110-pwmdac-dit"; >>>> + #sound-dai-cells = <0>; >>> >>> BTW, I don't see any resources here. Neither in the driver. I think you >>> just added this for driver, not for a real hardware. >> >> Yes, this is a dummy PWM-DAC transmitter as described in the title. The >> StarFive JH7110 PWM-DAC module doesn't need a hardware codec, but a >> dummy codec is needed for the driver. > > Bindings are no for drivers, therefore with such reasoning the answer > is: drop entire binding. If you think otherwise, please give me some > more details about the hardware.
I agreed. I will drop this binding and the compatible in patch 2. Thanks.
Best regards, Hal
| |