Messages in this thread | | | Date | Sun, 9 Jul 2023 22:53:27 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH v3 03/10] eventfs: adding eventfs dir add functions |
| |
On Mon, 10 Jul 2023 02:17:01 +0000 Nadav Amit <namit@vmware.com> wrote:
> > On Jul 9, 2023, at 6:54 PM, Steven Rostedt <rostedt@goodmis.org> wrote: > > > > + union { > > + struct rcu_head rcu; > > + struct llist_node llist; /* For freeing after RCU */ > > + }; > > The memory savings from using a union might not be worth the potential impact > of type confusion and bugs.
It's also documentation. The two are related, as one is the hand off to the other. It's not a random union, and I'd like to leave it that way.
-- Steve
| |