Messages in this thread | | | Date | Sun, 9 Jul 2023 18:40:20 -0500 | Subject | Re: [PATCH] Add struct ad9832_platform_data to the include/linux/iio | From | Madhumitha Prabakaran <> |
| |
On 7/8/23 09:45, Jonathan Cameron wrote: > On Sat, 8 Jul 2023 13:10:29 +0200 > Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > >> On Fri, Jul 07, 2023 at 04:15:53PM -0500, Madhumitha Prabakaran wrote: >>> Add struct ad9832_platform_data to the include/linux/iio >>> for maintaining code organization and clarity. >>> >>> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com> >>> --- >>> drivers/staging/iio/frequency/ad9832.c | 3 +-- >>> drivers/staging/iio/frequency/ad9832.h | 34 -------------------------- >>> include/linux/iio/frequency/ad9832.h | 30 +++++++++++++++++++++++ >> No, not yet, sorry. Staging drivers should be self-contained, why does >> this .c file need a .h file at all anyway? It should all just be in the >> .c file, can you do that instead? > This is an aged driver so still has definitions that would be included > from board files, hence the header. > > So Madhumitha, if you are looking at getting this driver out of staging > (which would be great!) then first job is convert it from platform data > to device tree (or better yet generic firmware bindings using linux/property.h)
Sure, I will take a look and work on convert it from platform data to generic
firmware bindings.
> A side effect of that is the header would go away as equivalent job would be > done by the dt-bindings yaml file. > > Jonathan > >> thanks, >> >> greg k-h
| |