lkml.org 
[lkml]   [2023]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 3/5] selftests/nolibc: report: align passed, skipped and failed
On Thu, Jul 06, 2023 at 05:10:08PM +0800, Zhangjin Wu wrote:
> align the test values for different runs and different architectures.
>
> Since the total number of tests is not bigger than 1000 currently, let's
> align them with "%03d".

%03d is not great for those who want to use them in scripts because it will
prepend zeroes. Better use %3d. Look for example:

$ x=$(printf "%03d\n" 19)
$ echo $x
019
$ echo $((x+1))
-bash: 019: value too great for base (error token is "019")

Instead:

$ printf "%3d\n" 19
19
$ x=$(printf "%3d\n" 19)
$ echo $x
19
$ echo $((x+1))
20

If you're fine with it I'll change your patch and commit message
accordingly.

Willy

\
 
 \ /
  Last update: 2023-07-09 10:52    [W:0.524 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site