lkml.org 
[lkml]   [2023]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 01/11] iio: adc: Update bindings for ADC7 name used on QCOM PMICs
    From
    On 08/07/2023 09:28, Jishnu Prakash wrote:
    > The name used initially for this version of Qualcomm Technologies, Inc.
    > PMIC ADC was ADC7, following the convention of calling the PMIC generation
    > PMIC7. However, the names were later amended internally to ADC5 Gen2 and
    > PMIC5 Gen2. In addition, the latest PMIC generation now is known as
    > PMIC5 Gen3 with ADC5 Gen3 supported on it. With this addition, it makes more
    > sense to correct the name for this version of ADCs to ADC5 Gen2 from ADC7.
    > Since this affects ADC devices across some PMICs, update the names accordingly.
    >
    > In order to avoid breaking the existing implementations of ADC7, add
    > support for ADC5 Gen2 first now and remove the ADC7 support in a later
    > patch.

    I don't understand and I do not see it explained, why do you remove
    ADC7. The patch is also doing way too many things at the same time...

    >
    > Signed-off-by: Jishnu Prakash <quic_jprakash@quicinc.com>
    > ---
    > .../bindings/iio/adc/qcom,spmi-vadc.yaml | 21 +++--
    > .../bindings/thermal/qcom-spmi-adc-tm5.yaml | 16 ++--
    > .../iio/qcom,spmi-adc5-gen2-pm8350.h | 64 +++++++++++++
    > .../iio/qcom,spmi-adc5-gen2-pm8350b.h | 89 +++++++++++++++++++
    > .../iio/qcom,spmi-adc5-gen2-pmk8350.h | 47 ++++++++++
    > .../iio/qcom,spmi-adc5-gen2-pmr735a.h | 29 ++++++
    > .../iio/qcom,spmi-adc5-gen2-pmr735b.h | 28 ++++++
    > include/dt-bindings/iio/qcom,spmi-vadc.h | 77 ++++++++++++++++

    Bindings are always separate patches. If this is commit for bindings, then:

    Please use subject prefixes matching the subsystem. You can get them for
    example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
    your patch is touching.



    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2023-07-09 19:18    [W:6.007 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site