Messages in this thread | | | Date | Fri, 7 Jul 2023 08:48:11 +0200 | Subject | Re: [PATCH] x86: Remove the arch_calc_vm_prot_bits() macro from the uapi | From | Thomas Huth <> |
| |
On 06/07/2023 22.30, Dave Hansen wrote: > On 7/6/23 13:22, Arnd Bergmann wrote: >> On Thu, Jul 6, 2023, at 21:02, Thomas Huth wrote: >>> The arch_calc_vm_prot_bits() macro uses VM_PKEY_BIT0 etc. which are >>> not part of the uapi, so the macro is completely useless for userspace. >>> It is also hidden behind the CONFIG_X86_INTEL_MEMORY_PROTECTION_KEYS >>> config switch which we shouldn't expose to userspace. Thus let's move >>> this macro into a new internal header instead. >>> >>> Signed-off-by: Thomas Huth <thuth@redhat.com> >> Fixes: 8f62c883222c9 ("x86/mm/pkeys: Add arch-specific VMA protection bits") >> Reviewed-by: Arnd Bergmann <arnd@arndb.de> >> >> It looks like this was introduced right after the uapi split, >> and probably is the result of an incorrect rebase. > > Yeah, I bet I just glossed over the "uapi" in the path. > > Is this causing any real problems? Or is it OK to just send it along > during the next merge window with other random cleanups?
As Arnd already said, it's not a real problem - I just came across this file while looking at the list in scripts/headers_install.sh.
Thomas
| |