lkml.org 
[lkml]   [2023]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Pending splice(file -> FIFO) excludes all other FIFO operations forever (was: ... always blocks read(FIFO), regardless of O_NONBLOCK on read side?)
On Thu, Jul 06, 2023 at 02:56:45PM -0700, Linus Torvalds wrote:
> +static int busy_pipe_buf_confirm(struct pipe_inode_info *pipe,
> + struct pipe_buffer *buf)
> +{
> + struct page *page = buf->page;
> +
> + if (folio_wait_bit_interruptible(page_folio(page), PG_locked))
> + return -EINTR;

Do we really want interruptible here rather than killable? That is,
do we want SIGWINCH or SIGALRM to result in a short read? I assume
it's OK to return a short read because userspace has explicitly asked
for O_NONBLOCK and can therefore be expected to actually check the
return value from read().

\
 
 \ /
  Last update: 2023-07-08 02:01    [W:0.076 / U:1.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site