Messages in this thread | | | Date | Thu, 6 Jul 2023 18:49:33 +0100 | Subject | Re: [RFT PATCH 1/3] arm64: dts: rockchip: correct audio-codec interrupt flag in eaidk-610 | From | Robin Murphy <> |
| |
On 2023-07-06 14:54, Krzysztof Kozlowski wrote: > On 05/07/2023 08:48, Krzysztof Kozlowski wrote: >> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. >> These are simple defines so they could be used in DTS but they will not >> have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE. >> >> Correct the interrupt flags, assuming the author of the code wanted same >> logical behavior behind the name "ACTIVE_xxx", this is: >> ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW > > This should be HIGH in both cases. I will send a v2.
Also the titles say "audio-codec" but they're all touching SDIO WiFi modules ;)
Cheers, Robin.
>> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts b/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts >> index d1f343345f67..6464ef4d113d 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts >> @@ -773,7 +773,7 @@ brcmf: wifi@1 { >> compatible = "brcm,bcm4329-fmac"; >> reg = <1>; >> interrupt-parent = <&gpio0>; >> - interrupts = <RK_PA3 GPIO_ACTIVE_HIGH>; >> + interrupts = <RK_PA3 IRQ_TYPE_LEVEL_HIGH>; > > Best regards, > Krzysztof > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip
| |