Messages in this thread | | | Date | Thu, 6 Jul 2023 18:15:07 +0530 | Subject | Re: [PATCH v2 1/2] arm64: dts: qcom: qdu1000-idp: Update reserved memory region | From | Komal Bajaj <> |
| |
On 7/5/2023 7:51 PM, Krzysztof Kozlowski wrote: > On 05/07/2023 13:06, Komal Bajaj wrote: >> Add missing reserved regions as described in QDU1000 memory map. >> >> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >> index 1d22f87fd238..47e5e31dde23 100644 >> --- a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >> @@ -448,6 +448,28 @@ &qupv3_id_0 { >> status = "okay"; >> }; >> >> +&reserved_memory{ >> + ecc_meta_data_mem: memory@e0000000{ > Missing spaces before '{'. I was correcting this already: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=66b14154e278807811d67de9fb0d5cc76638d07b > so it seems I need to keep doing the same. > > Anyway, the names should follow purpose, not "memory". See link from Konrad.
Sure, will correct it in the next patch set.
> > > Best regards, > Krzysztof >
| |