Messages in this thread | | | Date | Thu, 6 Jul 2023 18:50:38 +0800 | Subject | Re: [PATCH] cxl: fix CONFIG_FW_LOADER dependency | From | Xiao Yang <> |
| |
On 2023/7/3 19:29, Arnd Bergmann wrote: > From: Arnd Bergmann<arnd@arndb.de> > > When FW_LOADER is disabled, cxl fails to link: > > arm-linux-gnueabi-ld: drivers/cxl/core/memdev.o: in function `cxl_memdev_setup_fw_upload': > memdev.c:(.text+0x90e): undefined reference to `firmware_upload_register' > memdev.c:(.text+0x93c): undefined reference to `firmware_upload_unregister' > > In order to use the firmware_upload_register() function, both FW_LOADER > and FW_UPLOAD have to be enabled, which is a bit confusing. In addition, > the dependency is on the wrong symbol, as the caller is part of the > cxl_core.ko module, not the cxl_mem.ko module. > > Fixes: 9521875bbe005 ("cxl: add a firmware update mechanism using the sysfs firmware loader") > Signed-off-by: Arnd Bergmann<arnd@arndb.de>
Hi Arnd,
It makes sense.
Reviewed-by: Xiao Yang <yangx.jy@fujitsu.com>
Best Regards, Xiao Yang
| |