Messages in this thread Patch in this message | | | From | Jason-JH Lin (林睿祥) <> | Subject | Re: [PATCH v4 1/2] drm/mediatek: Add ability to support dynamic connector selection | Date | Fri, 7 Jul 2023 02:20:44 +0000 |
| |
Hi CK,
Thanks for the reviews.
On Tue, 2023-07-04 at 05:36 +0000, CK Hu (胡俊光) wrote: > Hi, Jason: > > On Fri, 2023-06-02 at 01:15 +0800, Jason-JH.Lin wrote: > > 1. Move output drm connector from each ddp_path array to connector > > array. > > 2. Add dynamic select available connector flow in crtc create and > > enable. > > > > Signed-off-by: Nancy Lin <nancy.lin@mediatek.com> > > Signed-off-by: Nathan Lu <nathan.lu@mediatek.com> > > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com> > > --- > > > > [snip] > > > > > + > > int mtk_ddp_comp_get_id(struct device_node *node, > > enum mtk_ddp_comp_type comp_type); > > unsigned int mtk_drm_find_possible_crtc_by_comp(struct drm_device > > *drm, > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > index 6dcb4ba2466c..0412a82c1ed0 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > @@ -185,7 +185,14 @@ static const unsigned int > > mt8188_mtk_ddp_main[] > > = { > > DDP_COMPONENT_GAMMA, > > DDP_COMPONENT_POSTMASK0, > > DDP_COMPONENT_DITHER0, > > - DDP_COMPONENT_DP_INTF0, > > +}; > > + > > +static const unsigned int mt8188_mtk_ddp_main_routes_0[] = { > > Only one component in route, so it's not necessary to use array to > store route. > > Regards, > CK
OK, I'll use array in [PATCH 2/2].
Regards, Jason-JH.Lin
> > > + DDP_COMPONENT_DP_INTF0 > > +}; > > + > > +static const struct mtk_drm_route mt8188_mtk_ddp_main_routes[] = { > > + {0, ARRAY_SIZE(mt8188_mtk_ddp_main_routes_0), > > mt8188_mtk_ddp_main_routes_0}, > > }; > >
| |