Messages in this thread | | | Subject | Re: [PATCH RFC 0/7] blk-mq: improve tag fair sharing | From | Yu Kuai <> | Date | Fri, 7 Jul 2023 09:15:19 +0800 |
| |
Hi,
在 2023/07/07 2:43, Bart Van Assche 写道: > On 7/4/23 20:17, Yu Kuai wrote: >> - currently borrowed tags will never be returned untill queue is idle, >> I should figure out a way to return borrowed tags if this queue is not >> busy, so that other queues can borrow tag from this queue. > > At least for UFS this is a significant disadvantage. If e.g. one SCSI > command is sent to the UFS WLUN every 20 seconds and the request queue > timeout is 30 seconds then borrowed tags will never be returned.
Ok, thanks for the notice. > > The complexity of this patch series is a concern to me. The complexity > of this patch series may be a barrier towards merging this patch series > in the upstream kernel.
Yeah, I see. Thanks for the review! However, all I have in mind will end up make this patch series more complicated, I'll try my best to make the code more readable in the next version.
Thanks, Kuai > > Thanks, > > Bart. > > > . >
| |