lkml.org 
[lkml]   [2023]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v1 1/2] spi: amlogic-spifc-a1: implement adjust_op_size()
Mon, Jul 03, 2023 at 12:45:17PM +0300, Martin Kurbanov kirjoitti:
> This enhancement eliminates the need for a loop in the
> amlogic_spifc_a1_exec_op() function and allows the SPI core to
> dynamically divide transactions into appropriately sized chunks.

...

> + if (!data_size) {

Why not positive check?

> + ret = amlogic_spifc_a1_request(spifc, false);
> + } else {
> + u32 mode = ilog2(op->data.buswidth);
>
> writel(0, spifc->base + SPIFC_A1_USER_DBUF_ADDR_REG);
>
> if (op->data.dir == SPI_MEM_DATA_IN)
> - ret = amlogic_spifc_a1_read(spifc,
> - op->data.buf.in + off,
> - block_size, dmode);
> + ret = amlogic_spifc_a1_read(spifc, op->data.buf.in,
> + data_size, mode);
> else
> - ret = amlogic_spifc_a1_write(spifc,
> - op->data.buf.out + off,
> - block_size, dmode);
> -
> - nbytes -= block_size;
> - off += block_size;
> - } while (nbytes != 0 && !ret);
> + ret = amlogic_spifc_a1_write(spifc, op->data.buf.out,
> + data_size, mode);
> + }

...

> +static int amlogic_spifc_a1_adjust_op_size(struct spi_mem *mem,
> + struct spi_mem_op *op)
> +{
> + op->data.nbytes = min_t(u32, op->data.nbytes, SPIFC_A1_BUFFER_SIZE);

I would rather use min() for strict type checking.
In this case it will require to have U/u suffix in the SPIFC_A1_BUFFER_SIZE
definition.

> + return 0;
> +}

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2023-07-05 12:17    [W:0.089 / U:1.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site