| From | Geert Uytterhoeven <> | Date | Tue, 4 Jul 2023 10:09:49 +0200 | Subject | Re: [PATCH v5 03/44] char: add HAS_IOPORT dependencies |
| |
Hi Niklas,
On Mon, May 22, 2023 at 12:51 PM Niklas Schnelle <schnelle@linux.ibm.com> wrote: > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add HAS_IOPORT as dependency for > those drivers using them. > > Co-developed-by: Arnd Bergmann <arnd@kernel.org> > Signed-off-by: Arnd Bergmann <arnd@kernel.org> > Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
Thanks for your patch, which is now commit 1fbb0b203574bb16 ("char: add HAS_IOPORT dependencies") upstream.
> --- a/drivers/char/Kconfig > +++ b/drivers/char/Kconfig
> @@ -340,7 +341,7 @@ config NVRAM > > config DEVPORT > bool "/dev/port character device" > - depends on ISA || PCI > + depends on HAS_IOPORT > default y > help > Say Y here if you want to support the /dev/port device. The /dev/port
FTR, this change makes DEVPORT show up on Atari with ATARI_ROM_ISA=y. I guess it doesn't matter much, though.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
|