Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Tue, 4 Jul 2023 10:01:32 +0200 | Subject | Re: [PATCH v4 1/5] video: Add auxiliary display drivers to Graphics support menu |
| |
Hi Javier,
On Tue, Jul 4, 2023 at 9:54 AM Javier Martinez Canillas <javierm@redhat.com> wrote: > Geert Uytterhoeven <geert@linux-m68k.org> writes: > > On Tue, Jul 4, 2023 at 1:05 AM Javier Martinez Canillas > > <javierm@redhat.com> wrote: > >> The drivers in this subsystem are for character-based LCD displays, which > >> can fall into the same category of the DRM/KMS and fbdev drivers that are > >> located under the "Graphics support" menu. Add auxdisplay there as well. > >> > >> Suggested-by: Thomas Zimmermann <tzimmermann@suse.de> > >> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> > > > > Thanks for your patch! > > > >> --- a/drivers/video/Kconfig > >> +++ b/drivers/video/Kconfig > >> @@ -30,6 +30,8 @@ if HAS_IOMEM > >> config HAVE_FB_ATMEL > >> bool > >> > >> +source "drivers/auxdisplay/Kconfig" > > > > This is inside the "if HAS_IOMEM" section, while there was no > > such limitation before. > > > > Gah, I missed that. Thanks a lot for pointing it out. > > If I move the source outside of the if block, are you OK with this patch? > > I think Thomas is correct and would make sense to put the character-based > drivers next to the DRM and fbdev drivers since all these are for display.
Yes, makes sense to me.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |