Messages in this thread | | | Date | Mon, 31 Jul 2023 16:04:18 +0300 | Subject | Re: [PATCH v14 12/12] drm/gem: Add _unlocked postfix to drm_gem_pin/unpin() | From | Dmitry Osipenko <> |
| |
On 7/25/23 10:53, Boris Brezillon wrote: > On Sun, 23 Jul 2023 02:47:46 +0300 > Dmitry Osipenko <dmitry.osipenko@collabora.com> wrote: > >> Make clear that drm_gem_pin/unpin() functions take reservation lock by >> adding _unlocked postfix to the function names. >> >> Suggested-by: Boris Brezillon <boris.brezillon@collabora.com> >> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> > > I'm still a bit confused by the fact we sometimes use the > xxx[_locked]() pattern (version without the _locked suffix takes the > lock) and other times the xxx[_unlocked]() pattern (version with the > _unlocked suffix takes the lock). It'd be good to chose one pattern and > stick to it, at least for all core functions...
After a more close look, agree that the _locked variant is much more common in DRM. Alright, I'll rename the drm-gem funcs.
-- Best regards, Dmitry
| |