Messages in this thread | | | Date | Mon, 31 Jul 2023 10:23:56 +0200 | Subject | Re: [PATCH 4/4] soc: qcom: aoss: Tidy up qmp_send() callers | From | Konrad Dybcio <> |
| |
On 31.07.2023 06:10, Bjorn Andersson wrote: > With qmp_send() handling variable length messages and string formatting > he callers of qmp_send() can be cleaned up to not care about these > things. > > Drop the QMP_MSG_LEN sized buffers and use the message formatting, as > appropriate. > > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> > --- If Alex is okay with that going through qcom:
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
One nit below.
[...]
> - snprintf(buf, sizeof(buf), > - "{class: volt_flr, event:zero_temp, res:%s, value:%s}", > - qmp_cdev->name, > - cdev_state ? "on" : "off"); > - > - ret = qmp_send(qmp_cdev->qmp, buf); > - > + ret = qmp_send(qmp_cdev->qmp, "{class: volt_flr, event:zero_temp, res:%s, value:%s}", There's a space after the first colon but not after the subsequent ones.
Konrad
| |