lkml.org 
[lkml]   [2023]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 4/4] soc: qcom: aoss: Tidy up qmp_send() callers
From
On 31.07.2023 06:10, Bjorn Andersson wrote:
> With qmp_send() handling variable length messages and string formatting
> he callers of qmp_send() can be cleaned up to not care about these
> things.
>
> Drop the QMP_MSG_LEN sized buffers and use the message formatting, as
> appropriate.
>
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> ---
If Alex is okay with that going through qcom:

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

One nit below.

[...]

> - snprintf(buf, sizeof(buf),
> - "{class: volt_flr, event:zero_temp, res:%s, value:%s}",
> - qmp_cdev->name,
> - cdev_state ? "on" : "off");
> -
> - ret = qmp_send(qmp_cdev->qmp, buf);
> -
> + ret = qmp_send(qmp_cdev->qmp, "{class: volt_flr, event:zero_temp, res:%s, value:%s}",
There's a space after the first colon but not after the subsequent
ones.

Konrad

\
 
 \ /
  Last update: 2023-07-31 10:25    [W:0.315 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site