lkml.org 
[lkml]   [2023]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] Modify the function to et the highest_perf value
From
On 7/31/23 19:47, Meng Li wrote:
> The previous function will be deprecated.
>
> Signed-off-by: Meng Li <li.meng@amd.com>
> ---

This actually has functional impact; doesn't it? Can you better
describe the reasoning and expected impact in the commit message?

> drivers/cpufreq/amd-pstate-ut.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/amd-pstate-ut.c b/drivers/cpufreq/amd-pstate-ut.c
> index 7f3fe2048981..9c889a4a0177 100644
> --- a/drivers/cpufreq/amd-pstate-ut.c
> +++ b/drivers/cpufreq/amd-pstate-ut.c
> @@ -145,8 +145,6 @@ static void amd_pstate_ut_check_perf(u32 index)
> struct cpufreq_policy *policy = NULL;
> struct amd_cpudata *cpudata = NULL;
>
> - highest_perf = amd_get_highest_perf();
> -
> for_each_possible_cpu(cpu) {
> policy = cpufreq_cpu_get(cpu);
> if (!policy)
> @@ -161,6 +159,7 @@ static void amd_pstate_ut_check_perf(u32 index)
> return;
> }
>
> + highest_perf = cppc_perf.highest_perf;
> nominal_perf = cppc_perf.nominal_perf;
> lowest_nonlinear_perf = cppc_perf.lowest_nonlinear_perf;
> lowest_perf = cppc_perf.lowest_perf;
> @@ -172,6 +171,7 @@ static void amd_pstate_ut_check_perf(u32 index)
> return;
> }
>
> + highest_perf = AMD_CPPC_HIGHEST_PERF(cap1);
> nominal_perf = AMD_CPPC_NOMINAL_PERF(cap1);
> lowest_nonlinear_perf = AMD_CPPC_LOWNONLIN_PERF(cap1);
> lowest_perf = AMD_CPPC_LOWEST_PERF(cap1);

\
 
 \ /
  Last update: 2023-08-01 03:11    [W:0.037 / U:1.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site