Messages in this thread | | | Date | Mon, 31 Jul 2023 13:01:30 -0700 | Subject | Re: [PATCH -next] net: hisilicon: fix the return value handle and remove redundant netdev_err() for platform_get_irq() | From | Jesse Brandeburg <> |
| |
On 7/31/2023 12:38 AM, Ruan Jinjie wrote: > There is no possible for platform_get_irq() to return 0 > and the return value of platform_get_irq() is more sensible > to show the error reason. > > And there is no need to call the netdev_err() function directly to print > a custom message when handling an error from platform_get_irq() function as > it is going to display an appropriate error message in case of a failure. > > Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Makes sense
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
| |