Messages in this thread | | | Date | Mon, 31 Jul 2023 23:01:51 +0200 | From | Sebastian Reichel <> | Subject | Re: [PATCH v2] hsi: controllers: Remove error checking for debugfs_create_dir() |
| |
Hi,
On Wed, Jul 26, 2023 at 08:30:46PM +0800, Wang Ming wrote: > It is expected that most callers should _ignore_ the errors > return by debugfs_create_dir() in bond_debug_reregister().
bond_debug_reregister()?
> Signed-off-by: Wang Ming <machel@vivo.com> > --- > drivers/hsi/controllers/omap_ssi_core.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/hsi/controllers/omap_ssi_core.c b/drivers/hsi/controllers/omap_ssi_core.c > index 84ba8b875..57c63053f 100644 > --- a/drivers/hsi/controllers/omap_ssi_core.c > +++ b/drivers/hsi/controllers/omap_ssi_core.c > @@ -115,8 +115,6 @@ static int ssi_debug_add_ctrl(struct hsi_controller *ssi)
function can become void, if errors are ignored.
> > /* SSI controller */ > omap_ssi->dir = debugfs_create_dir(dev_name(&ssi->device), NULL); > - if (!omap_ssi->dir) > - return -ENOMEM;
What about the second debugfs_create_dir() call in the same function?
> > debugfs_create_file("regs", S_IRUGO, omap_ssi->dir, ssi, > &ssi_regs_fops);
-- Sebastian [unhandled content-type:application/pgp-signature] | |