Messages in this thread | | | Date | Mon, 31 Jul 2023 11:19:25 -0700 | Subject | Re: [PATCH v2 1/7] dt-bindings: soc: qcom: Add qcom-pbs bindings | From | Anjelique Melendez <> |
| |
On 7/26/2023 12:53 AM, Krzysztof Kozlowski wrote: > On 25/07/2023 21:34, Anjelique Melendez wrote: >> Add binding for the Qualcomm Programmable Boot Sequencer device. >> >> Signed-off-by: Anjelique Melendez <quic_amelende@quicinc.com> >> --- >> .../bindings/soc/qcom/qcom-pbs.yaml | 40 +++++++++++++++++++ >> 1 file changed, 40 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom-pbs.yaml > > > Again not tested. > > Also, you missed comments. :( > > This is a friendly reminder during the review process. > > It seems my previous comments were not fully addressed. Maybe my > feedback got lost between the quotes, maybe you just forgot to apply it. > Please go back to the previous discussion and either implement all > requested changes or keep discussing them. > > Thank you. > > > Best regards, > Krzysztof > Hi Krzysztof,
Sorry about the testing, found that my dt_binding_checker was out dated and that is why it has not been picking up those dt_binding errors :/
I went back to take a look at the original comments I missed and just wanted to list them for a quick double check.
1. Rename binding to be qcom,pbs so that it matches compatible 2. Include Soc specific compatibles i.e. compatible: items: - enum: - qcom,pmi632-pbs - const: qcom,pbs 3. Fix the example node
Thanks, Anjelique
| |