Messages in this thread | | | From | Suren Baghdasaryan <> | Date | Mon, 31 Jul 2023 11:17:49 -0700 | Subject | Re: [PATCH] PSI: select KERNFS as needed |
| |
On Mon, Jul 31, 2023 at 11:14 AM Suren Baghdasaryan <surenb@google.com> wrote: > > On Sun, Jul 30, 2023 at 8:07 PM Randy Dunlap <rdunlap@infradead.org> wrote: > > > > Users of KERNFS should select it to enforce its being built, so > > do this to prevent a build error. > > > > In file included from ../kernel/sched/build_utility.c:97: > > ../kernel/sched/psi.c: In function 'psi_trigger_poll': > > ../kernel/sched/psi.c:1479:17: error: implicit declaration of function 'kernfs_generic_poll' [-Werror=implicit-function-declaration] > > 1479 | kernfs_generic_poll(t->of, wait); > > > > Fixes: aff037078eca ("sched/psi: use kernfs polling functions for PSI trigger polling") > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > > Reported-by: kernel test robot <lkp@intel.com>
shouldn't this include: Closes: https://lore.kernel.org/oe-kbuild-all/202307310732.r65EQFY0-lkp@intel.com/ ?
> > Link: lore.kernel.org/r/202307310732.r65EQFY0-lkp@intel.com > > Cc: Johannes Weiner <hannes@cmpxchg.org> > > Cc: Suren Baghdasaryan <surenb@google.com> > > Cc: Ingo Molnar <mingo@redhat.com> > > Cc: Peter Zijlstra <peterz@infradead.org> > > Cc: Juri Lelli <juri.lelli@redhat.com> > > Cc: Vincent Guittot <vincent.guittot@linaro.org> > > Acked-by: Suren Baghdasaryan <surenb@google.com> > > Thanks! > > > > --- > > init/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff -- a/init/Kconfig b/init/Kconfig > > --- a/init/Kconfig > > +++ b/init/Kconfig > > @@ -629,6 +629,7 @@ config TASK_IO_ACCOUNTING > > > > config PSI > > bool "Pressure stall information tracking" > > + select KERNFS > > help > > Collect metrics that indicate how overcommitted the CPU, memory, > > and IO capacity are in the system.
| |