lkml.org 
[lkml]   [2023]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] lsm: change 'target' parameter to 'const' in security_capget LSM hook
On Mon, Jul 31, 2023 at 12:07:31PM +0500, Khadija Kamran wrote:
> Three LSMs register the implementations for the "capget" hook: AppArmor,
> SELinux, and the normal capability code. Looking at the function
> implementations we may observe that the first parameter "target" is not
> changing.
>
> Mark the first argument "target" of LSM hook security_capget(...) as
> "const" since it will not be changing in the LSM hook.


The commit message may be simplified, from this:
[PATCH 1/2] lsm: change 'target' parameter to 'const' in security_capget LSM hook

to something like this:
[PATCH 1/2] lsm: Constify the target parameter in security_capget()

"Constify" is the commonly used language in git logs.
See git log --pretty=oneline --abbrev-commit | grep Constify

Alison

--snip --

>

\
 
 \ /
  Last update: 2023-07-31 19:03    [W:0.042 / U:2.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site