Messages in this thread | | | Date | Mon, 31 Jul 2023 10:02:17 -0700 | From | Alison Schofield <> | Subject | Re: [PATCH 1/2] lsm: change 'target' parameter to 'const' in security_capget LSM hook |
| |
On Mon, Jul 31, 2023 at 12:07:31PM +0500, Khadija Kamran wrote: > Three LSMs register the implementations for the "capget" hook: AppArmor, > SELinux, and the normal capability code. Looking at the function > implementations we may observe that the first parameter "target" is not > changing. > > Mark the first argument "target" of LSM hook security_capget(...) as > "const" since it will not be changing in the LSM hook.
The commit message may be simplified, from this: [PATCH 1/2] lsm: change 'target' parameter to 'const' in security_capget LSM hook
to something like this: [PATCH 1/2] lsm: Constify the target parameter in security_capget()
"Constify" is the commonly used language in git logs. See git log --pretty=oneline --abbrev-commit | grep Constify
Alison
--snip --
>
| |