Messages in this thread | | | Date | Mon, 31 Jul 2023 18:37:30 +0200 | Subject | Re: [PATCH v2 1/2] nvme-auth: unlock mutex in one place only | From | Hannes Reinecke <> |
| |
On 7/31/23 16:51, Mark O'Donovan wrote: > Signed-off-by: Mark O'Donovan <shiftee@posteo.net> > Reviewed-by: Christoph Hellwig <hch@lst.de> > Reviewed-by: Sagi Grimberg <sagi@grimberg.me> > --- > drivers/nvme/host/auth.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/nvme/host/auth.c b/drivers/nvme/host/auth.c > index daf5d144a8ea..e1a98647c3a2 100644 > --- a/drivers/nvme/host/auth.c > +++ b/drivers/nvme/host/auth.c > @@ -758,12 +758,11 @@ static void nvme_queue_auth_work(struct work_struct *work) > __func__, chap->qid); > mutex_lock(&ctrl->dhchap_auth_mutex); > ret = nvme_auth_dhchap_setup_host_response(ctrl, chap); > + mutex_unlock(&ctrl->dhchap_auth_mutex); > if (ret) { > - mutex_unlock(&ctrl->dhchap_auth_mutex); > chap->error = ret; > goto fail2; > } > - mutex_unlock(&ctrl->dhchap_auth_mutex); > > /* DH-HMAC-CHAP Step 3: send reply */ > dev_dbg(ctrl->device, "%s: qid %d send reply\n", If you insist.
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman
| |