lkml.org 
[lkml]   [2023]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v9 06/10] serial: sc16is7xx: fix regression with GPIO configuration
    On Tue, Jul 25, 2023 at 10:23:38AM -0400, Hugo Villeneuve wrote:
    > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
    >
    > Commit 679875d1d880 ("sc16is7xx: Separate GPIOs from modem control lines")
    > and commit 21144bab4f11 ("sc16is7xx: Handle modem status lines")
    > changed the function of the GPIOs pins to act as modem control
    > lines without any possibility of selecting GPIO function.
    >
    > As a consequence, applications that depends on GPIO lines configured
    > by default as GPIO pins no longer work as expected.
    >
    > Also, the change to select modem control lines function was done only
    > for channel A of dual UART variants (752/762). This was not documented
    > in the log message.
    >
    > Allow to specify GPIO or modem control line function in the device
    > tree, and for each of the ports (A or B).
    >
    > Do so by using the new device-tree property named
    > "nxp,modem-control-line-ports" (property added in separate patch).
    >
    > When registering GPIO chip controller, mask-out GPIO pins declared as
    > modem control lines according to this new DT property.
    >
    > Fixes: 679875d1d880 ("sc16is7xx: Separate GPIOs from modem control lines")
    > Fixes: 21144bab4f11 ("sc16is7xx: Handle modem status lines")
    > Cc: <stable@vger.kernel.org> # 6.1.x: 95982fad dt-bindings: sc16is7xx: Add property to change GPIO function
    > Cc: <stable@vger.kernel.org> # 6.1.x: 1584d572 serial: sc16is7xx: refactor GPIO controller registration
    > Cc: <stable@vger.kernel.org> # 6.1.x: ac2caa5a serial: sc16is7xx: remove obsolete out_thread label
    > Cc: <stable@vger.kernel.org> # 6.1.x: d90961ad serial: sc16is7xx: mark IOCONTROL register as volatile
    > Cc: <stable@vger.kernel.org> # 6.1.x: 6dae3bad serial: sc16is7xx: fix broken port 0 uart init

    Where are these git commit ids from? I don't see them in Linus's tree,
    how are they supposed to be picked up by the stable developers if they
    are not valid ones?

    confused,

    greg k-h

    \
     
     \ /
      Last update: 2023-07-31 17:59    [W:5.318 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site