Messages in this thread | | | Date | Mon, 31 Jul 2023 17:13:15 +0200 | From | "" <> | Subject | Re: [PATCH] tty: serial: fsl_lpuart: Clear the error flags by writing 1 for lpuart32 platforms |
| |
On Mon, Jul 31, 2023 at 05:50:46AM +0000, Sherry Sun wrote: > > > > -----Original Message----- > > From: Jiri Slaby <jirislaby@kernel.org> > > Sent: 2023年7月31日 13:24 > > To: Sherry Sun <sherry.sun@nxp.com>; gregkh@linuxfoundation.org; > > tomonori.sakita@sord.co.jp; atsushi.nemoto@sord.co.jp > > Cc: linux-serial@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx > > <linux-imx@nxp.com> > > Subject: Re: [PATCH] tty: serial: fsl_lpuart: Clear the error flags by writing 1 > > for lpuart32 platforms > > > > On 31. 07. 23, 3:50, Sherry Sun wrote: > > > Do not read the data register to clear the error flags for lpuart32 > > > platforms, the additional read may cause the receive FIFO underflow > > > since the DMA has already read the data register. > > > Now all lpuart32 platforms support write 1 to clear those error bits, > > > > What does this "Now" mean? Will this change break some older platforms? > > Hi Jiri, > > Sorry for the confusion, maybe the "Now" should be removed here. I can > send a V2 to improve the commit message if needed.
Please do, thanks!
greg k-h
| |