lkml.org 
[lkml]   [2023]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 3/5] rtc: ds1685: use EXPORT_SYMBOL_GPL for ds1685_rtc_poweroff
    From
    On 7/31/2023 04:38, Christoph Hellwig wrote:
    > ds1685_rtc_poweroff is only used externally via symbol_get, which was
    > only ever intended for very internal symbols like this one. Use
    > EXPORT_SYMBOL_GPL for it so that symbol_get can enforce only being used
    > on EXPORT_SYMBOL_GPL symbols.
    >
    > Signed-off-by: Christoph Hellwig <hch@lst.de>
    > ---
    > drivers/rtc/rtc-ds1685.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/rtc/rtc-ds1685.c b/drivers/rtc/rtc-ds1685.c
    > index 0f707be0eb87fa..04dbf35cf3b706 100644
    > --- a/drivers/rtc/rtc-ds1685.c
    > +++ b/drivers/rtc/rtc-ds1685.c
    > @@ -1432,7 +1432,7 @@ ds1685_rtc_poweroff(struct platform_device *pdev)
    > unreachable();
    > }
    > }
    > -EXPORT_SYMBOL(ds1685_rtc_poweroff);
    > +EXPORT_SYMBOL_GPL(ds1685_rtc_poweroff);
    > /* ----------------------------------------------------------------------- */
    >
    >

    Acked-by: Joshua Kinard <kumba@gentoo.org>

    \
     
     \ /
      Last update: 2023-07-31 17:09    [W:3.350 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site