Messages in this thread | | | Date | Mon, 31 Jul 2023 11:08:41 -0400 | Subject | Re: [PATCH 3/5] rtc: ds1685: use EXPORT_SYMBOL_GPL for ds1685_rtc_poweroff | From | Joshua Kinard <> |
| |
On 7/31/2023 04:38, Christoph Hellwig wrote: > ds1685_rtc_poweroff is only used externally via symbol_get, which was > only ever intended for very internal symbols like this one. Use > EXPORT_SYMBOL_GPL for it so that symbol_get can enforce only being used > on EXPORT_SYMBOL_GPL symbols. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > drivers/rtc/rtc-ds1685.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-ds1685.c b/drivers/rtc/rtc-ds1685.c > index 0f707be0eb87fa..04dbf35cf3b706 100644 > --- a/drivers/rtc/rtc-ds1685.c > +++ b/drivers/rtc/rtc-ds1685.c > @@ -1432,7 +1432,7 @@ ds1685_rtc_poweroff(struct platform_device *pdev) > unreachable(); > } > } > -EXPORT_SYMBOL(ds1685_rtc_poweroff); > +EXPORT_SYMBOL_GPL(ds1685_rtc_poweroff); > /* ----------------------------------------------------------------------- */ > >
Acked-by: Joshua Kinard <kumba@gentoo.org>
| |