lkml.org 
[lkml]   [2023]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] ath6kl: Fix debugfs_create_dir error checking
    Date
    The debugfs_create_dir function returns ERR_PTR
    in case of error and the correct way to check an
    error is 'IS_ERR' inline function.
    This patch will replace the null-comparison with IS_ERR

    This issue was found with the help of Coccinelle.
    ./drivers/net/wireless/ath/ath6kl/debug.c:1796:6-21: Wrong debugfs call error processing on line 1796

    Signed-off-by: Atul Raut <rauji.raut@gmail.com>
    ---
    drivers/net/wireless/ath/ath6kl/debug.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/wireless/ath/ath6kl/debug.c b/drivers/net/wireless/ath/ath6kl/debug.c
    index 433a047f3747..505af195e299 100644
    --- a/drivers/net/wireless/ath/ath6kl/debug.c
    +++ b/drivers/net/wireless/ath/ath6kl/debug.c
    @@ -1793,7 +1793,7 @@ int ath6kl_debug_init_fs(struct ath6kl *ar)
    {
    ar->debugfs_phy = debugfs_create_dir("ath6kl",
    ar->wiphy->debugfsdir);
    - if (!ar->debugfs_phy)
    + if (IS_ERR(ar->debugfs_phy))
    return -ENOMEM;

    debugfs_create_file("tgt_stats", 0400, ar->debugfs_phy, ar,
    --
    2.34.1
    \
     
     \ /
      Last update: 2023-07-31 04:47    [W:4.597 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site