Messages in this thread | | | From | Johannes Roith <> | Subject | Re: [PATCH] hid-mcp2200: added driver for GPIOs of MCP2200 | Date | Sun, 30 Jul 2023 21:37:12 +0200 |
| |
Hello Andi, hello Christophe,
thanks for the feedback and the hints. I will add most of your suggestions to the driver and submit a new patch, this time with a correct Version Label.
I need to use dynamic memory allocation for the data passed to hid_hw_output_report, overwise the function doesn't work, 0 bytes will be sent. The memory has to be allocated dynamically because of the DMA usage in the background.
But all the over feedback looks good and will be added to the driver.
Best regards, Johannes
| |