Messages in this thread | | | Date | Sun, 30 Jul 2023 14:24:37 +0200 | Subject | Re: [PATCH 13/22] Input: ili210x - use device core to create driver-specific device attributes | From | Marek Vasut <> |
| |
On 7/30/23 13:38, Greg Kroah-Hartman wrote: > On Sat, Jul 29, 2023 at 05:07:17PM +0200, Marek Vasut wrote: >> On 7/29/23 02:51, Dmitry Torokhov wrote: >>> Instead of creating driver-specific device attributes with >>> devm_device_add_group() have device core do this by setting up dev_groups >>> pointer in the driver structure. >>> >>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> >>> --- >>> drivers/input/touchscreen/ili210x.c | 15 +++++---------- >>> 1 file changed, 5 insertions(+), 10 deletions(-) >>> >>> diff --git a/drivers/input/touchscreen/ili210x.c b/drivers/input/touchscreen/ili210x.c >>> index ad6828e4f2e2..31ffdc2a93f3 100644 >>> --- a/drivers/input/touchscreen/ili210x.c >>> +++ b/drivers/input/touchscreen/ili210x.c >>> @@ -876,7 +876,7 @@ static ssize_t ili210x_firmware_update_store(struct device *dev, >>> static DEVICE_ATTR(firmware_update, 0200, NULL, ili210x_firmware_update_store); >>> -static struct attribute *ili210x_attributes[] = { >>> +static struct attribute *ili210x_attrs[] = { >>> &dev_attr_calibrate.attr, >>> &dev_attr_firmware_update.attr, >>> &dev_attr_firmware_version.attr, >>> @@ -904,10 +904,11 @@ static umode_t ili210x_attributes_visible(struct kobject *kobj, >>> return attr->mode; >>> } >>> -static const struct attribute_group ili210x_attr_group = { >>> - .attrs = ili210x_attributes, >>> +static const struct attribute_group ili210x_group = { >>> + .attrs = ili210x_attrs, >> >> Is all the renaming really necessary and relevant to this patch ? > > Yes, it's needed for the __ATTRIBUTE_GROUPS() macro.
Ah ok
| |