lkml.org 
[lkml]   [2023]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] xtensa: ISS: fix etherdev leak in error return path
On Mon, Jul 3, 2023 at 9:02 AM Markus Elfring <Markus.Elfring@web.de> wrote:
>
> > > We fixed a bug where the variable dev
> > > was not freed before return.
> …
> > > arch/xtensa/platforms/iss/network.c | 1 +
> …
> > Applied to my xtensa tree with the following commit message:
> >
> > xtensa: ISS: fix etherdev leak in error return path
> >
> > iss_net_configure frees etherdev in all error return paths except one
> > where register_netdevice fails. Add missing free_netdev to that path.
>
> * Did you add the tag “Fixes” because of the completed resource cleanup
> for the implementation of the function “iss_net_configure”?
>
> * How do you think about to replace any statements by the source code
> “goto err_free_netdev;” here?

I've scrapped that patch and committed the other one instead. See

https://lore.kernel.org/lkml/CAMo8BfKe1nR+UP1WiUWFX0E7GSEfHsF8bZapsUYu3NFTnA8_AQ@mail.gmail.com/
https://lore.kernel.org/lkml/20230703170335.1340104-1-jcmvbkbc@gmail.com/

--
Thanks.
-- Max

\
 
 \ /
  Last update: 2023-07-03 19:13    [W:0.038 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site