Messages in this thread | | | Date | Mon, 3 Jul 2023 16:01:28 +0200 | Subject | Re: [PATCH 2/5] dt-bindings: serial: geni-qcom: Allow no qup-core icc path | From | Krzysztof Kozlowski <> |
| |
On 03/07/2023 15:31, Konrad Dybcio wrote: > Some SoCs (like SM8150 and SM8250) don't seem to provide a qup-core path. > Allow such case. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > .../bindings/serial/qcom,serial-geni-qcom.yaml | 26 +++++++++++++++------- > 1 file changed, 18 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml b/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml > index dd33794b3534..a0acba57bc06 100644 > --- a/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml > +++ b/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml > @@ -25,14 +25,6 @@ properties: > clock-names: > const: se > > - interconnects: > - maxItems: 2 > - > - interconnect-names: > - items: > - - const: qup-core > - - const: qup-config
Instead please keep the definition of the fields in top-level properties with the widest constraints, e.g. interconnects: minItems: 1 maxItems: 2
interconnect-names: minItems: 1 items: - const: qup-core - const: qup-config
If there was allOf:if:then per variant, this could be further customized.
Best regards, Krzysztof
| |