Messages in this thread | | | Date | Mon, 3 Jul 2023 16:28:14 +0300 | From | Leon Romanovsky <> | Subject | Re: [PATCH] RDMA/bnxt_re: fix verbs undefined build errors |
| |
On Fri, Jun 30, 2023 at 05:30:59PM -0700, Randy Dunlap wrote: > When INFINIBAND_USER_ACCESS is not set, the bnxt_re driver has > build errors: > > ERROR: modpost: "uverbs_idr_class" [drivers/infiniband/hw/bnxt_re/bnxt_re.ko] undefined! > ERROR: modpost: "ib_uverbs_get_ucontext_file" [drivers/infiniband/hw/bnxt_re/bnxt_re.ko] undefined! > ERROR: modpost: "uverbs_destroy_def_handler" [drivers/infiniband/hw/bnxt_re/bnxt_re.ko] undefined! > > Handle this case by making the driver depend on INFINIBAND_USER_ACCESS. > > Fixes: 592e8b3226a2 ("RDMA/bnxt_re: Add bnxt_re driver build support") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Selvin Xavier <selvin.xavier@broadcom.com> > Cc: Jason Gunthorpe <jgg@nvidia.com> > Cc: Leon Romanovsky <leonro@nvidia.com> > Cc: linux-rdma@vger.kernel.org > Cc: Devesh Sharma <devesh.sharma@broadcom.com> > Cc: Somnath Kotur <somnath.kotur@broadcom.com> > Cc: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com> > Cc: Doug Ledford <dledford@redhat.com> > --- > drivers/infiniband/hw/bnxt_re/Kconfig | 1 + > 1 file changed, 1 insertion(+)
I liked this variant [1] more as bnxt_re driver can theoretically work without INFINIBAND_USER_ACCESS too.
[1] https://lore.kernel.org/all/20230703113025.356682-1-arnd@kernel.org
Thanks
| |