lkml.org 
[lkml]   [2023]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] drivers: use free_netdev before return
From


On 03/07/2023 14:11, Minjie Du wrote:
> We will replace the old version of
> undo_user_init and use out_free_netdev
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
> arch/um/drivers/vector_kern.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c
> index af7f6fd4c..7ae6ab8df 100644
> --- a/arch/um/drivers/vector_kern.c
> +++ b/arch/um/drivers/vector_kern.c
> @@ -1646,7 +1646,7 @@ static void vector_eth_configure(
> err = register_netdevice(dev);
> rtnl_unlock();
> if (err)
> - goto out_undo_user_init;
> + goto out_free_netdev;
>
> spin_lock(&vector_devices_lock);
> list_add(&device->list, &vector_devices);
> @@ -1654,9 +1654,6 @@ static void vector_eth_configure(
>
> return;
>
> -out_undo_user_init:
> - free_netdev(dev);
> - return;
> out_free_netdev:
> free_netdev(dev);
> out_free_device:

Acked-By: "Anton Ivanov" <anton.ivanov@cambridgegreys.com>

--
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/

\
 
 \ /
  Last update: 2023-07-03 15:20    [W:0.024 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site