Messages in this thread | | | Date | Mon, 3 Jul 2023 14:19:38 +0100 | Subject | Re: [PATCH v2] drivers: use free_netdev before return | From | Anton Ivanov <> |
| |
On 03/07/2023 14:11, Minjie Du wrote: > We will replace the old version of > undo_user_init and use out_free_netdev > > Signed-off-by: Minjie Du <duminjie@vivo.com> > --- > arch/um/drivers/vector_kern.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c > index af7f6fd4c..7ae6ab8df 100644 > --- a/arch/um/drivers/vector_kern.c > +++ b/arch/um/drivers/vector_kern.c > @@ -1646,7 +1646,7 @@ static void vector_eth_configure( > err = register_netdevice(dev); > rtnl_unlock(); > if (err) > - goto out_undo_user_init; > + goto out_free_netdev; > > spin_lock(&vector_devices_lock); > list_add(&device->list, &vector_devices); > @@ -1654,9 +1654,6 @@ static void vector_eth_configure( > > return; > > -out_undo_user_init: > - free_netdev(dev); > - return; > out_free_netdev: > free_netdev(dev); > out_free_device:
Acked-By: "Anton Ivanov" <anton.ivanov@cambridgegreys.com>
-- Anton R. Ivanov Cambridgegreys Limited. Registered in England. Company Number 10273661 https://www.cambridgegreys.com/
| |