lkml.org 
[lkml]   [2023]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 5/8] thermal/drivers/int3400: Use thermal zone device wrappers
From

Hi Srinivas,

do you agree with the changes in patches 5 and 6 ?

Thanks

-- Daniel


On 25/05/2023 16:01, Daniel Lezcano wrote:
> The driver is accessing the thermal zone device structure but the
> accessors are already existing and we want to consolidate the thermal
> core code by preventing accesses to the internals from the drivers.
>
> Let's use these accessors.
>
> On the other side, the code is getting directly the temperature from
> tz->temperature, but the temperature is a faked on, so we can replace
> this access by the fake temp and remove the thermal zone device
> structure access.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> .../thermal/intel/int340x_thermal/int3400_thermal.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> index 810231b59dcd..66e34241b33a 100644
> --- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> +++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> @@ -15,6 +15,7 @@
> #define INT3400_THERMAL_TABLE_CHANGED 0x83
> #define INT3400_ODVP_CHANGED 0x88
> #define INT3400_KEEP_ALIVE 0xA0
> +#define INT3400_FAKE_TEMP (20 * 1000) /* faked temp sensor with 20C */
>
> enum int3400_thermal_uuid {
> INT3400_THERMAL_ACTIVE = 0,
> @@ -453,6 +454,7 @@ static void int3400_notify(acpi_handle handle,
> void *data)
> {
> struct int3400_thermal_priv *priv = data;
> + struct device *dev;
> char *thermal_prop[5];
> int therm_event;
>
> @@ -475,12 +477,14 @@ static void int3400_notify(acpi_handle handle,
> return;
> }
>
> - thermal_prop[0] = kasprintf(GFP_KERNEL, "NAME=%s", priv->thermal->type);
> - thermal_prop[1] = kasprintf(GFP_KERNEL, "TEMP=%d", priv->thermal->temperature);
> + dev = thermal_zone_device(priv->thermal);
> +
> + thermal_prop[0] = kasprintf(GFP_KERNEL, "NAME=%s", thermal_zone_device_type(priv->thermal));
> + thermal_prop[1] = kasprintf(GFP_KERNEL, "TEMP=%d", INT3400_FAKE_TEMP);
> thermal_prop[2] = kasprintf(GFP_KERNEL, "TRIP=");
> thermal_prop[3] = kasprintf(GFP_KERNEL, "EVENT=%d", therm_event);
> thermal_prop[4] = NULL;
> - kobject_uevent_env(&priv->thermal->device.kobj, KOBJ_CHANGE, thermal_prop);
> + kobject_uevent_env(&dev->kobj, KOBJ_CHANGE, thermal_prop);
> kfree(thermal_prop[0]);
> kfree(thermal_prop[1]);
> kfree(thermal_prop[2]);
> @@ -490,7 +494,7 @@ static void int3400_notify(acpi_handle handle,
> static int int3400_thermal_get_temp(struct thermal_zone_device *thermal,
> int *temp)
> {
> - *temp = 20 * 1000; /* faked temp sensor with 20C */
> + *temp = INT3400_FAKE_TEMP;
> return 0;
> }
>

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

\
 
 \ /
  Last update: 2023-07-03 12:50    [W:0.053 / U:0.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site