Messages in this thread | | | From | Shinichiro Kawasaki <> | Subject | Re: [PATCH blktests v2 0/3] More fixes for FC enabling | Date | Mon, 3 Jul 2023 05:43:01 +0000 |
| |
On Jun 28, 2023 / 17:16, Daniel Wagner wrote: > I (think) address all the feedback I got from Sagi and Shinichiro except one. > The _have_nvme_cli_context() (previously _nvme_cli_support_context()) function > is still there. I didn't find any other good way to achieve this and I found in > blktests another function doing the same: _have_fio_zbd_zonemode().
I found that the latest blktests fix for the hostnqn/hostid issue created conflict with the 2nd patch in this series. Sorry about that. (Actually, I guess this series could be enough for the issue...)
Daniel, I can fix the conflict and repost the series to the list. Or you can fix the conflict by yourself. Please let me know your preference.
Other than that, I think the three patches are good enough to apply.
| |