Messages in this thread | | | From | Andreas Gruenbacher <> | Date | Mon, 3 Jul 2023 11:17:13 +0200 | Subject | Re: [PATCH v3 0/6] gfs2: kmap{_atomic} conversion to kmap_local_{page/folio} |
| |
Hi Deepak,
On Thu, Jun 29, 2023 at 11:48 PM Deepak R Varma <drv@mailo.com> wrote: > This patch series proposes to replace the kmap/kmap_atomic implementation to the > preferred kmap_local_* APIs. > > The code blocks for this module where kmap/kmap_atomic calls are implemented do > not appear to depend on disabling page-faults or preemption. Hence such code > blocks are safe for converting to improved kmap_local_{page,folio} APIs. > > Note: The proposed patches are build tested only. > > Initially, only a single patch was sent and now being converted into a patch > series including the other files/functions of this module. Hence all patches, > that are included for the first time in this series are also marked as v3. > > Changes in v3: > - Patch set introduced to include all gfs2 kmap conversions > - Patches 3/6 through 6/6 are included to build the series > - Initial stand-alone patch split into 2 patches [1/6 and 2/6]
I have already merged version 2 of this patch series and I've fixed up the remaining issues in follow-up patches; see the cluster-devel mailing list:
https://listman.redhat.com/archives/cluster-devel/2023-June/024391.html https://listman.redhat.com/archives/cluster-devel/2023-June/024392.html https://listman.redhat.com/archives/cluster-devel/2023-June/024393.html
As well as our for-next branch:
https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/log/?h=for-next
As far as I can see, there is nothing in v3 of your patches that I haven't addressed already. Please speak out if I've missed anything.
Thanks, Andreas
> > Changes in v2: > - 3/6 to 6/6: None. > - 1/6 + 2/6: Correct patch description for the replacement function name from > kmap_local_folio to kmap_local_page > > Deepak R Varma (6): > gfs2: Replace kmap_atomic() by kmap_local_page() in stuffed_readpage > gfs2: Replace kmap_atomic()+memcpy by memcpy_from_page() > gfs2: Replace kmap() by kmap_local_page() in gfs2_unstuffer_page > gfs2: Replace kmap_atomic() by kmap_local_page() in lops.c > gfs2: Replace kmap() by kmap_local_page() in gfs2_read_super > gfs2: Replace kmap_atomic() by kmap_local_page() in > gfs2_write_buf_to_page > > fs/gfs2/aops.c | 13 ++++++------- > fs/gfs2/bmap.c | 4 ++-- > fs/gfs2/lops.c | 12 ++++++------ > fs/gfs2/ops_fstype.c | 4 ++-- > fs/gfs2/quota.c | 4 ++-- > 5 files changed, 18 insertions(+), 19 deletions(-) > > -- > 2.34.1 > > >
| |