Messages in this thread | | | From | "Quan, Evan" <> | Subject | RE: [PATCH V5 1/9] drivers core: Add support for Wifi band RF mitigations | Date | Tue, 4 Jul 2023 03:25:23 +0000 |
| |
[AMD Official Use Only - General]
> -----Original Message----- > From: Andrew Lunn <andrew@lunn.ch> > Sent: Saturday, July 1, 2023 8:25 AM > To: Limonciello, Mario <Mario.Limonciello@amd.com> > Cc: Quan, Evan <Evan.Quan@amd.com>; rafael@kernel.org; lenb@kernel.org; > Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian > <Christian.Koenig@amd.com>; Pan, Xinhui <Xinhui.Pan@amd.com>; > airlied@gmail.com; daniel@ffwll.ch; johannes@sipsolutions.net; > davem@davemloft.net; edumazet@google.com; kuba@kernel.org; > pabeni@redhat.com; mdaenzer@redhat.com; > maarten.lankhorst@linux.intel.com; tzimmermann@suse.de; > hdegoede@redhat.com; jingyuwang_vip@163.com; Lazar, Lijo > <Lijo.Lazar@amd.com>; jim.cromie@gmail.com; bellosilicio@gmail.com; > andrealmeid@igalia.com; trix@redhat.com; jsg@jsg.id.au; arnd@arndb.de; > linux-kernel@vger.kernel.org; linux-acpi@vger.kernel.org; amd- > gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux- > wireless@vger.kernel.org; netdev@vger.kernel.org > Subject: Re: [PATCH V5 1/9] drivers core: Add support for Wifi band RF > mitigations > > > Right now there are stubs for non CONFIG_WBRF as well as other patches > > are using #ifdef CONFIG_WBRF or having their own stubs. Like mac80211 > > patch looks for #ifdef CONFIG_WBRF. > > > > I think we should pick one or the other. > > > > Having other subsystems #ifdef CONFIG_WBRF will make the series easier > > to land through multiple trees; so I have a slight leaning in that direction. > > #ifdef in C files is generally not liked because it makes build testing harder. > There are more permutations to build. It is better to use > > if (IS_ENABLED(CONFIG_WBTR)) { > } > > so that the code is compiled, and them throw away because > IS_ENABLED(CONFIG_WBTR) evaluates to false. > > However, if the stubs are done correctly, the driver should not care. I doubt > this is used in any sort of hot path where every instruction counts. OK, will update as suggested.
Evan > > Andrew
| |