lkml.org 
[lkml]   [2023]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/4] pinctrl: amd: Unify debounce handling into amd_pinconf_set()
From
On 7/3/23 16:33, andy.shevchenko@gmail.com wrote:
> Fri, Jun 30, 2023 at 02:47:15PM -0500, Mario Limonciello kirjoitti:
>> Debounce handling is done in two different entry points in the driver.
>> Unify this to make sure that it's always handled the same.
>
> ...
>
>> -static int amd_gpio_set_debounce(struct gpio_chip *gc, unsigned offset,
>> - unsigned debounce)
>> +static int amd_gpio_set_debounce(struct amd_gpio *gpio_dev, unsigned offset,
>> + unsigned debounce)
>
> Side note: Are you going to fix unsigned --> unsigned int?
> The former is discouraged.
>
> ...
>
>> +out:
>
> out_unlock: ?
>
>> raw_spin_unlock_irqrestore(&gpio_dev->lock, flags);
>>
>> return ret;
>

Ack, thanks will adjust both.

\
 
 \ /
  Last update: 2023-07-04 04:16    [W:0.042 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site