Messages in this thread | | | Date | Mon, 3 Jul 2023 21:13:09 -0500 | Subject | Re: [PATCH 2/4] pinctrl: amd: Drop pull up select configuration | From | Mario Limonciello <> |
| |
On 7/3/23 16:32, andy.shevchenko@gmail.com wrote: > Fri, Jun 30, 2023 at 02:47:14PM -0500, Mario Limonciello kirjoitti: >> pinctrl-amd currently tries to program bit 19 of all GPIOs to select >> either a 4kΩ or 8hΩ pull up, but this isn't what bit 19 does. Bit >> 19 is marked as reserved, even in the latest platforms documentation. >> >> Drop this programming functionality. > > Can it be that documentation is not (yet) updated? >
No; I double checked documentation across products from last few years as well as products to be coming out in the next few years and this bit is consistently marked "Reserved".
> Where, btw, did the original code come from? Perhaps it may shed some light > on this. >
It's from the *very beginning* of the driver.
dbad75dd1f25 ("pinctrl: add AMD GPIO driver support.")
Original author isn't at AMD anymore, so I can't ask them. I would guess that it was something that was discussed to be supported but never actually was.
Maybe Shyam and Basavaraj have some other thoughts on this bit.
| |