Messages in this thread | | | Date | Fri, 28 Jul 2023 16:41:51 +0200 | Subject | Re: [PATCH v2 1/2] perf probe: add test for regression introduced by switch to die_get_decl_file | From | Georg Müller <> |
| |
Am 27.07.23 um 19:45 schrieb Ian Rogers: > On Wed, Jun 28, 2023 at 1:25 AM Georg Müller <georgmueller@gmx.net> wrote: > > Thanks for the test Georg! By directly relying on gcc this test fails > for me in some constrained environments, like containers. I think > there should be a skip if gcc isn't present. A different option is to > just build the test code into the perf binary itself as a test > workload: > https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/tests/workloads?h=perf-tools-next > > Wdyt? Thanks, > Ian >
I prepare a commit which checks for gcc and skips the test in this case.
I think building thi test code into the perf binary itself is not an option here, since the test relies on a special setup of using -flto for one of the compilation units.
There is also a cleanup issue if anything fails. This will be included in the patch as well.
Best regards, Georg
| |